-
Notifications
You must be signed in to change notification settings - Fork 4
Improve Relink UI and add People Picker (CFM-125) #316
base: develop
Are you sure you want to change the base?
Conversation
|
Arlen's original comments (from Slack):
|
a87f181 to
492afbc
Compare
|
Simplified and rebased against the latest develop. The original comment (above) from Slack is largely no longer accurate. (1) is outdated - there is no unlocking. (2) Is not a correct description, but there are some peculiarities when searching with the picker (I'll create a different ticket as this gets tracked down), and (3) is also outdated. The new string utilities function is not needed (and has been removed from this PR). |
f43c5d9 to
27b2a57
Compare
| msgid "ExternalIdentities.target_person_id" | ||
| msgstr "Target Person" | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this a field specific to ExternalIdentities? Why not just make the key target_person_id?
| @@ -87,6 +87,7 @@ public function beforeRender(EventInterface $event) { | |||
| // Pull the Person name for breadcrumb rendering | |||
|
|
|||
| $link = $this->getPrimaryLink(true); | |||
| $this->populateAutoViewVars(); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this here? I'm guessing because you need it for relink(), in which case it should go in relink(). (populateAutoViewVars will be called by other functions such as add(), meaning it will be called multiple times for other actions. We might ultimately want to refactor the call so it is only called by StandardController::beforeRender(), but that's beyond the scope of this issue.)
| // XXX Unfortunately CAKEPHP doe not create a viewvar space for the element | ||
| // XXX Unfortunately CAKEPHP does not create a viewvar space for the element |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doh?
No description provided.